Only situate if chunk char length is less than specified #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 58.94% 58.94% -0.01%
==========================================
Files 114 114
Lines 18198 18203 +5
==========================================
+ Hits 10727 10729 +2
- Misses 7471 7474 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amaloney
requested changes
Jun 19, 2025
Comment on lines
+89
to
+94
| Controls whether to add a `llm_context` key to the metadata | ||
| with contextual information about the chunks. | ||
| If set to True, all chunks will be situated. | ||
| If set to an integer, only chunks with a character | ||
| count less than or equal to this value will be situated. | ||
| If set to False, no chunks will be situated.""", |
There was a problem hiding this comment.
I would like an example in the doc, because I do not fully understand what is being added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to embed vega-lite docs, trying to be more efficient about situating.