Breaking Change in move to NPM?

[anativhq]

Hi Guys,

Thanks for adding the client to NPM.

I think you should know that the change you have made to publish the module to npm has broken the package for users on the old version. @theninj4 @pmcnr-hx

I have the old package linked in my package.json like this
"jsonapi-client": "holidayextras/jsonapi-client",

I think you've renamed the module to @holidayextras/jsonapi-client so now when my CI server tries to install and build, it cannot resolve the module.

Obviously I should have been more careful about referencing the module in my package, but I thought you should know about the potential issue.

build output

Failed to compile.

Error in ./src/containers/campaign-manage/index.js
Module not found: 'jsonapi-client' in /Users/blah/Documents/dyzio/git/dweb3/src/containers/campaign-manage

Any questions or advice, let me know. I shall install the package using the SHA to fix it right now.

[pmcnr-hx]

Hi @anativhq. Thank you for getting in touch. Apologies for the inconvenience, but unfortunately there is no way we can keep the backward compatibility on this one. We needed to rename the package in order to publish to NPM. We should not have advised to install as "jsonapi-client": "holidayextras/jsonapi-client" and instead have asked for a specific version tag to be used (e.g. "jsonapi-client": "holidayextras/jsonapi-client#vx.y.z" which would have avoid the problem you're experiencing. Hopefully you'll be able to upgrade soon to the NPM module which won't have these problems. Thanks again for reporting the issue (I'm leaving it open for a while so it can be found for users with a similar issue).

[anativhq]

Hi @pmcnr-hx.

Thanks for getting back to me. Yep I locked the version in my package.json to fix the problem.

"jsonapi-client": "github:holidayextras/jsonapi-client#00a02ddfe48a56d2d18ec797ccbab8de70c74aac",

I guess following semantic versioning the jump to version 1.0.0 is a breaking change so my bad really! :-)