[ALS-9754] Add OR clauses and groupings for filters #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPeck
reviewed
Oct 15, 2025
JamesPeck
reviewed
Oct 24, 2025
| Prepare for Analysis | ||
| </button> | ||
| </div> | ||
| <button |
There was a problem hiding this comment.
We should probably remove this now
JamesPeck
reviewed
Oct 24, 2025
Comment on lines
185
to
+190
| {#each $filters as filter} | ||
| <FilterComponent {filter} /> | ||
| {/each} | ||
| {#each $genomicFilters as filter} | ||
| <FilterComponent {filter} /> | ||
| {/each} |
There was a problem hiding this comment.
Not a huge fan of breaking out genomic filters. I think we will need all filters to be in the same list in the future. Its probably fine for MVP though.
JamesPeck
reviewed
Oct 24, 2025
| values?: string[], | ||
| ): CategoricalFilterInterface { | ||
| const filter: Filter = { | ||
| parent: undefined, |
JamesPeck
reviewed
Oct 24, 2025
| export function createRequiredFilter(searchResult: SearchResult) { | ||
| export function createRequiredFilter(searchResult: SearchResult): CategoricalFilterInterface { | ||
| const filter: Filter = { | ||
| parent: undefined, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.