Skip to content

Don't re-review when new commits are pushed #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Don't re-review when new commits are pushed #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 0 additions & 17 deletions src/approve.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,23 +179,6 @@ test("when a review is commented", async () => {
expect(createReview.isDone()).toBe(true);
});

test("when an old commit has already been approved", async () => {
apiMocks.getUser();
apiMocks.getPull();
apiMocks.getReviews(200, [
{
user: { login: "hmarr" },
commit_id: "6a9ec7556f0a7fa5b49527a1eea4878b8a22d2e0",
state: "APPROVED",
},
]);
const createReview = apiMocks.createReview();

await approve("gh-tok", ghContext());

expect(createReview.isDone()).toBe(true);
});

test("when a review has already been approved by another user", async () => {
apiMocks.getUser();
apiMocks.getPull();
Expand Down
3 changes: 1 addition & 2 deletions src/approve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ export async function approve(
core.info(`Commit SHA is ${prHead}`);

const alreadyReviewed = reviews.some(
({ user, commit_id, state }) =>
user?.login === login && commit_id == prHead && state === "APPROVED"
({ user, state }) => user?.login === login && state === "APPROVED"
);
const outstandingReviewRequest = pr.requested_reviewers?.some(
(reviewer) => reviewer.login == login
Expand Down