Better defaults for native build backend cache keys (#15705) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary This change extends the default initialized projects with scikit and maturin build backends to ensure that the rust or C++ build gets invoked when a source file changes. ## Test Plan `cargo run init cppextension-test --build-backend=scikit` followed by manual testing of the behaviour of the resulting project under `uv run --with jupyter jupyter lab` and changes to the source file of the extension. Analogous for `cargo run init maturin-test --build-backend=maturin `. ## Relevant Issues The question of why the python extension is not rebuilt on source changes has been discussed in #15701 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change extends the default initialized projects with scikit and maturin build backends to ensure that the rust or C++ build gets invoked when a source file changes.
Test Plan
cargo run init cppextension-test --build-backend=scikitfollowed by manual testing of the behaviour of the resulting project underuv run --with jupyter jupyter laband changes to the source file of the extension.Analogous for
cargo run init maturin-test --build-backend=maturin.Relevant Issues
The question of why the python extension is not rebuilt on source changes has been discussed in
astral-sh#15701 (comment).
Summary
Test Plan