-
Notifications
You must be signed in to change notification settings - Fork 108
fix: tx-id-page-fixes #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tx-id-page-fixes #2445
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for sharing these @BLuEScioN , it's looking great so far. Here are my revision notes:
![]()
![]()
![]()
Screen.Recording.2025-08-04.at.15.25.34.mov
![]()
![]()
![]() ![]() ![]()
![]() This tag also seems to be slightly different to the ones used in the table? ![]()
![]()
![]()
![]()
![]()
![]()
![]() ![]()
![]() ![]()
![]()
![]()
![]() ![]()
![]()
![]() ![]()
![]() Can we also replace the title for "Burn block details"? I changed this recently to make it more accurate
![]() ![]()
![]() ![]()
![]()
![]() ![]()
![]() ![]()
![]()
![]()
![]()
![]() ![]()
![]() ![]()
![]() ![]()
Screen.Recording.2025-08-04.at.15.35.14.mov |
"The loading skeleton is taking the layout from the old design. Is it possible to apply the skeleton to the new layout? Or alternatively just swap for a loading spinner" Once we remove the feature flag, the skeleton will not be shown |
@ginny-d There is horizontal padding on the column headers. Do you want me to remove that? |
In that case, should the same horizontal padding be applied to the table cells? |
@ginny-d |
@ginny-d |
@ginny-d |
All of the cells have padding, header cells and row cells. But for some reason the header cell content had padding. So padding inside padding is the issue. I just removed the inner padding |
@ginny-d |
@ginny-d I have addresed your feedback. This PR is ready for another look |
That's ok, we should only highlight/use STX, BTC, and sBTC icons, as the "native" currencies of Stacks. We don't need to use any additional icons for other tokens |
Sorry it wasn't clear, so on this one: |
cd78389
to
caa43ca
Compare
caa43ca
to
8722988
Compare
I understand the confusion here. The tabs themselves haven’t changed, the difference comes from how font styles are applied at different sizes.
This causes the visual difference you’re seeing between small and large tab sizes. |
8722988
to
c8b35ac
Compare
c8b35ac
to
70fda66
Compare
70fda66
to
8c16487
Compare
8c16487
to
a7b38af
Compare
What type of PR is this? (check all applicable)
Description
Issue ticket number and link
Checklist:
Screenshots (if appropriate):