remove some deprecated code #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Symfony 2.7, the setDefaultOptions() method of AbstractType and AbstractExtensionType has been deprecated in favor of the new configureOptions() method
setDefaultOptions is deprecated
setDefaults Is deprecated
There was a problem hiding this comment.
use Symfony\Component\OptionsResolver\OptionsResolver;
needed instead
There was a problem hiding this comment.
You are absolutely right, I forgot to add it;
|
also, as this will introduce BC break, I'll consider to increase major version number |
|
probably the best solution to mantain the bundle compatible with Symfony version lower to 2.7 can be the this: http://stackoverflow.com/a/28671099/3625883 |
The methods setAllowedValues(), addAllowedValues(), setAllowedTypes() and addAllowedTypes() were changed to modify one option at a time instead of batch processing options. The old API exists for backwards compatibility, but will be removed in Symfony 3.0. https://github.com/symfony/symfony/blob/2.8/UPGRADE-2.6.md#optionsresolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 2.7, the setDefaultOptions() method of AbstractType and AbstractExtensionType has been deprecated in favor of the new configureOptions() method
http://symfony.com/blog/new-in-symfony-2-7-form-and-validator-updates