Skip to content

Conversation

@hboutemy
Copy link
Contributor

fix GHA config to pass the artifact:compare:

  • disable signature
  • accept known failure for now

later, once xjc is updated and you don't expect failure any more, you can drop the -Dcompare.fail=false config

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hboutemy
Copy link
Contributor Author

I reworked it: did the first install and the verify artifact:compare steps with the same profile
I don't know what the all profile does, but that's not what we want to check rebuild against

@hboutemy
Copy link
Contributor Author

hboutemy commented Aug 12, 2025

that brings expected result for now https://github.com/highsource/jaxb-tools/actions/runs/16917744950/job/47935824435#step:5:5711

= the 4 failing artifacts because xjc creates non-reproducible content for episodes eclipse-ee4j/jaxb-ri#1796

@laurentschoelens
Copy link
Collaborator

I don't know what the all profile does, but that's not what we want to check rebuild against

The all profile allow to verify the tests modules for project to run

As you pointed out, that's not what we want to check rebuild against

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentschoelens laurentschoelens merged commit 155b1fd into highsource:master Sep 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants