Skip to content

Conversation

@laurentschoelens
Copy link
Collaborator

Fixes #589

Remove commons-io dependency

@laurentschoelens laurentschoelens added the dependencies Pull requests that update a dependency file label Apr 30, 2025
@laurentschoelens laurentschoelens added this to the 4.0.10 milestone Apr 30, 2025
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

private String readFromInputStream(InputStream inputStream)
throws IOException {
StringBuilder resultStringBuilder = new StringBuilder();
try (BufferedReader br = new BufferedReader(new InputStreamReader(inputStream, "UTF-8"))) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, use StandardCharsets.UTF_8 constant

@mattrpav mattrpav merged commit b8d2c34 into highsource:master Apr 30, 2025
3 checks passed
@mattrpav mattrpav deleted the jt-589-2 branch April 30, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove commons-io

2 participants