[#582] enhance resolution artifact process if not success #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@davidmichaelkarr created this PR to add details and fail-fast when resolution fails due to incorrect project configuration |
Collaborator
|
Possible to add a unit test that demonstrates failure of resolution and effectiveness of the change to log to the user? |
Collaborator
Author
I'd like to but I've been able to reproduce the issue myself :( |
Collaborator
Author
laurentschoelens
left a comment
laurentschoelens
left a comment
There was a problem hiding this comment.
Fix if block
maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/util/ArtifactUtils.java
Outdated
Show resolved
Hide resolved
laurentschoelens
force-pushed
the
jt-582
branch
from
b98fd4d to
16006d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582
Add extra details if resolution failed at some point instead of failing later with NPE