Skip to content

fix(clj) Fix broken/inconsistent highlighting for $, Numbers, namespaced maps, HINT mode. Add charachter, regex and punctuation modes. #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 10, 2021
Merged

fix(clj) Fix broken/inconsistent highlighting for $, Numbers, namespaced maps, HINT mode. Add charachter, regex and punctuation modes. #3397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dd161d5
Match names contianing `$`
MrEbbinghaus Nov 9, 2021
e1fda58
Add regex for all clojure number formats
MrEbbinghaus Nov 9, 2021
c7f1f47
Add character highlighting
MrEbbinghaus Nov 9, 2021
7af493c
Fix inconsistent namespaced map highlighting
MrEbbinghaus Nov 9, 2021
82850bd
Add regex highlighting
MrEbbinghaus Nov 9, 2021
7cd7549
Remove HINT mode from clojure
MrEbbinghaus Nov 9, 2021
3048320
Remove incorrect code from test
MrEbbinghaus Nov 9, 2021
cbb6d4e
Add punctuation mode for comma
MrEbbinghaus Nov 9, 2021
5b45dbd
Add latest clojure fixes to CHANGES.md
MrEbbinghaus Nov 10, 2021
f3c6a21
Add more tests for different numbers
MrEbbinghaus Nov 10, 2021
70c463f
Break up Number regex into maintainable parts
MrEbbinghaus Nov 10, 2021
4ee86ac
Break up Character regex into maintainable parts
MrEbbinghaus Nov 10, 2021
0d1cdfe
Set relevance for single character match to 0.
MrEbbinghaus Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/markup/clojure/globals_definition.expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
(<span class="hljs-keyword">defn</span> <span class="hljs-title">clojure-function</span> [args]
(<span class="hljs-name"><span class="hljs-built_in">let</span></span> [string <span class="hljs-string">&quot;multiline\nstring&quot;</span>
regexp <span class="hljs-regex">#&quot;regexp&quot;</span>
number <span class="hljs-number">100</span>,<span class="hljs-number">000</span>
number <span class="hljs-number">100000</span>
booleans [<span class="hljs-literal">false</span> <span class="hljs-literal">true</span>]
keyword <span class="hljs-symbol">::the-keyword</span>]
<span class="hljs-comment">;; this is comment</span>
Expand Down
2 changes: 1 addition & 1 deletion test/markup/clojure/globals_definition.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
(defn clojure-function [args]
(let [string "multiline\nstring"
regexp #"regexp"
number 100,000
number 100000
booleans [false true]
keyword ::the-keyword]
;; this is comment
Expand Down