Fix zlib compression #901
Merged
Fix zlib compression #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
============================================
+ Coverage 68.30% 68.41% +0.11%
Complexity 1397 1397
============================================
Files 207 207
Lines 7430 7431 +1
Branches 631 631
============================================
+ Hits 5075 5084 +9
+ Misses 2019 2013 -6
+ Partials 336 334 -2
|
|
Wow, that's a fast fix, hadn't had the time yet to look at the previous PR that added the failing test. Thanks for finding the bug. I'm guessing this is due to the change to using standard JDK gzip instead of depending on jzlib. |
hierynomus
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #893 and builds on top of #900, which provided a failing test.