Skip to content

Have newStatefulSFTPClient return StatefulSFTPClient #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

Have newStatefulSFTPClient return StatefulSFTPClient #876

merged 1 commit into from
Jul 14, 2023

Conversation

cebaa
Copy link
Contributor

@cebaa cebaa commented Jul 4, 2023

Avoids casting requirement:

StatefulSFTPClient statefulSftpClient = (StatefulSFTPClient) sshClient.newStatefulSFTPClient();

@cebaa cebaa requested a review from hierynomus as a code owner July 4, 2023 18:03
exceptionfactory
exceptionfactory reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable adjustment given the return type of the method.

@hierynomus hierynomus merged commit e7614db into hierynomus:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hierynomus hierynomus hierynomus approved these changes

+1 more reviewer

@exceptionfactory exceptionfactory exceptionfactory left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cebaa @hierynomus @exceptionfactory