ByteBuffer.array() must not be used as it does not take the real buff… #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er size into account and returns the whole buffer up to its capacity. Fixes hierynomus#745.
hierynomus
approved these changes
Nov 22, 2021
|
Thanks! |
vladimirlagunov
pushed a commit
to vladimirlagunov/sshj
that referenced
this pull request
Jan 21, 2022
…er size into account and returns the whole buffer up to its capacity. Fixes hierynomus#745. (hierynomus#746) Co-authored-by: Yves Langisch <[email protected]> (cherry picked from commit d8697c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er size into account and returns the whole buffer up to its capacity.