fix(Transaction): prevent regeneration of manually set TransactionId #1017
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atharva1723
force-pushed
the
TransactionId-bug
branch
from
b6dc6f8 to
b901b44
Compare
rwalworth
reviewed
Oct 3, 2025
Contributor
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
one small thing otherwise looks good!
Atharva1723
force-pushed
the
TransactionId-bug
branch
from
17adc59 to
bca3461
Compare
rwalworth
reviewed
Oct 3, 2025
Atharva1723
force-pushed
the
TransactionId-bug
branch
from
70c1c2b to
8c27a5b
Compare
Contributor
Author
|
please review on this pr |
rwalworth
approved these changes
Oct 13, 2025
rwalworth
previously approved these changes
Oct 21, 2025
gsstoykov
previously approved these changes
Nov 18, 2025
gsstoykov
reviewed
Nov 18, 2025
Contributor
gsstoykov
left a comment
gsstoykov
left a comment
There was a problem hiding this comment.
@Atharva1723 seems there is some problem with the signatures.
Atharva1723
dismissed stale reviews from rwalworth and gsstoykov
via
df83993
Atharva1723
force-pushed
the
TransactionId-bug
branch
2 times, most recently
from
70a4910 to
b37782e
Compare
Signed-off-by: Atharva <[email protected]>
Signed-off-by: Atharva <[email protected]>
Signed-off-by: Atharva <[email protected]>
Signed-off-by: Atharva <[email protected]>
Atharva1723
force-pushed
the
TransactionId-bug
branch
from
b37782e to
621ecd5
Compare
Contributor
Author
|
The signatures are done now |
rwalworth
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
mTransactionIdManualSetflag to track if a TransactionId was set manually.mTransactionIdManualSetis true, the TransactionId will not be regenerated.TransactionIdshould not be regenerated if set manually by a user #652