Skip to content

Conversation

nickeynikolovv
Copy link
Contributor

This PR fixes failing modification test for contractCallRedirectApprove. Change in the deploy branch is also needed because the PRECOMPILE_CONTRACT is redeployed

Fixes #11661

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv nickeynikolovv self-assigned this Aug 5, 2025
@nickeynikolovv nickeynikolovv requested a review from a team as a code owner August 5, 2025 12:24
@nickeynikolovv nickeynikolovv requested a review from nirbosl August 5, 2025 12:24
@lfdt-bot
Copy link

lfdt-bot commented Aug 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@nickeynikolovv nickeynikolovv added enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API labels Aug 5, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.67% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a55c3fb) 36390 34087 93.67%
Head commit (19dfc2c) 59832 (+23442) 36497 (+2410) 61.00% (-32.67%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11726) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@steven-sheehy steven-sheehy added this to the 0.136.0 milestone Aug 5, 2025
@steven-sheehy steven-sheehy merged commit b71c2d7 into main Aug 5, 2025
32 of 33 checks passed
@steven-sheehy steven-sheehy deleted the fix-failing-k6-redirect-approve-test branch August 5, 2025 18:22
@steven-sheehy steven-sheehy added bug Type: Something isn't working and removed enhancement Type: New feature labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contractCallRedirectApprove performance test fails
3 participants