Skip to content

Conversation

sdimitrov9
Copy link
Contributor

@sdimitrov9 sdimitrov9 commented Aug 1, 2025

Description:
Add support for enabling/disabling js endpoints rewritten in rest-java api. Falling back to js api in case of endpoint in rest-java is disabled,

Example disabling rest-java endpoint and and falling back to its rest service analogues:
helm upgrade -i -n test --create-namespace mirror charts/hedera-mirror -f charts/hedera-mirror/values-prod.yaml -f charts/hedera-mirror/values-v2.yml -f values-minikube.yml --set restjava.routes.networkStake = false

Related issue(s):

Fixes #11644

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sdimitrov9 sdimitrov9 self-assigned this Aug 1, 2025
@sdimitrov9 sdimitrov9 added rest Area: REST API chart Area: Helm charts labels Aug 1, 2025
@lfdt-bot
Copy link

lfdt-bot commented Aug 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Aug 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.38% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0913cf8) 36340 34039 93.67%
Head commit (33c49a8) 59836 (+23496) 36673 (+2634) 61.29% (-32.38%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11704) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from be84c35 to edc15a9 Compare August 1, 2025 08:06
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from edc15a9 to 463b233 Compare August 1, 2025 08:13
@sdimitrov9 sdimitrov9 marked this pull request as ready for review August 1, 2025 12:58
@sdimitrov9 sdimitrov9 requested a review from a team as a code owner August 1, 2025 12:58
@sdimitrov9 sdimitrov9 added the enhancement Type: New feature label Aug 1, 2025
@steven-sheehy steven-sheehy added this to the 0.136.0 milestone Aug 2, 2025
@steven-sheehy steven-sheehy removed the rest Area: REST API label Aug 2, 2025
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from b9943a7 to 876e22e Compare August 4, 2025 12:33
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from 11265bc to b75c3c8 Compare August 5, 2025 10:33
xin-hedera
xin-hedera previously approved these changes Aug 5, 2025
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve to unblock the PR

kselveliev
kselveliev previously approved these changes Aug 5, 2025
@sdimitrov9 sdimitrov9 dismissed stale reviews from kselveliev and xin-hedera via 745c27d August 6, 2025 10:31
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from 745c27d to d4e25b4 Compare August 6, 2025 10:36
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch 2 times, most recently from 15de7a7 to c078dce Compare August 6, 2025 10:56
@sdimitrov9 sdimitrov9 force-pushed the 11644-support-gradual-rollout-of-rest-java-api branch from c078dce to 33c49a8 Compare August 6, 2025 11:13
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 43d84b7 into main Aug 6, 2025
33 of 35 checks passed
@steven-sheehy steven-sheehy deleted the 11644-support-gradual-rollout-of-rest-java-api branch August 6, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Area: Helm charts enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support enabled flag for individual rest-java routes in Helm
5 participants