-
Notifications
You must be signed in to change notification settings - Fork 127
Add flag to enable and disable endpoints exposure through ingress #11704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to enable and disable endpoints exposure through ingress #11704
Conversation
Signed-off-by: sdimitrov9 <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
be84c35
to
edc15a9
Compare
Signed-off-by: sdimitrov9 <[email protected]>
edc15a9
to
463b233
Compare
Signed-off-by: sdimitrov9 <[email protected]>
b9943a7
to
876e22e
Compare
Signed-off-by: sdimitrov9 <[email protected]>
11265bc
to
b75c3c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve to unblock the PR
745c27d
to
d4e25b4
Compare
15de7a7
to
c078dce
Compare
Signed-off-by: sdimitrov9 <[email protected]>
c078dce
to
33c49a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Add support for enabling/disabling js endpoints rewritten in rest-java api. Falling back to js api in case of endpoint in rest-java is disabled,
Example disabling rest-java endpoint and and falling back to its rest service analogues:
helm upgrade -i -n test --create-namespace mirror charts/hedera-mirror -f charts/hedera-mirror/values-prod.yaml -f charts/hedera-mirror/values-v2.yml -f values-minikube.yml --set restjava.routes.networkStake = false
Related issue(s):
Fixes #11644
Checklist