Show null topic fee schedule key when cleared #11688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
xin-hedera
added
bug
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
jnels124
approved these changes
Jul 29, 2025
xin-hedera
deleted the
11687-topics-endpoint-shows-empty-list-for-fee_exempt_key_list-and-fee_schedule_key-when-they-are-cleared
branch
xin-hedera
added a commit
that referenced
this pull request
Jul 29, 2025
- Show null fee_schedule_key when it's set to an empty key list key to indicate it's cleared - Update acceptance test Signed-off-by: Xin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the fee schedule key bug in topic by id endpoint
fee_schedule_keywhen it's set to an empty key list key to indicate it's clearedRelated issue(s):
Fixes #11687
Notes for reviewer:
Checklist