Skip to content

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Jul 28, 2025

Description:

  • skip clean shutdown when restoring from snapshot
  • ensure all steps can be reran if previous run resulted in failure
  • force delete pods that don't scale down
  • make master version upgrade optional
  • increase timeout for clean shutdown and allow retries
  • ensure gke version upgrade is bumping to later version

Related issue(s):

Fixes #11662

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 added this to the 0.136.0 milestone Jul 28, 2025
@jnels124 jnels124 self-assigned this Jul 28, 2025
@jnels124 jnels124 added the enhancement Type: New feature label Jul 28, 2025
@jnels124 jnels124 linked an issue Jul 28, 2025 that may be closed by this pull request
@lfdt-bot
Copy link

lfdt-bot commented Jul 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 28, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.69% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (41ef086) 36336 34035 93.67%
Head commit (65f8257) 59764 (+23428) 36445 (+2410) 60.98% (-32.69%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11686) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

jnels124 added 3 commits July 28, 2025 11:51
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 force-pushed the 11662-enhance-citus-runbook-scripts branch from a9a624c to 8e14843 Compare July 29, 2025 04:43
@jnels124 jnels124 marked this pull request as ready for review July 29, 2025 04:43
@jnels124 jnels124 requested a review from a team as a code owner July 29, 2025 04:43
@jnels124 jnels124 requested a review from IvanKavaldzhiev July 29, 2025 04:43
@jnels124 jnels124 marked this pull request as draft July 29, 2025 12:35
@jnels124 jnels124 marked this pull request as ready for review July 29, 2025 13:14
@jnels124 jnels124 requested a review from xin-hedera July 29, 2025 15:43
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 changed the title runbook script improvements Runbook script improvements Jul 30, 2025
@jnels124 jnels124 merged commit 0913cf8 into main Jul 30, 2025
31 of 33 checks passed
@jnels124 jnels124 deleted the 11662-enhance-citus-runbook-scripts branch July 30, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Citus Runbook Scripts
3 participants