Skip to content

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Jul 25, 2025

Description:

  • Fix remaining acceptance tests for non-zero shard/realm

Related issue(s):

Fixes #11427

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added this to the 0.136.0 milestone Jul 25, 2025
@jnels124 jnels124 self-assigned this Jul 25, 2025
@jnels124 jnels124 requested a review from a team as a code owner July 25, 2025 20:28
@jnels124 jnels124 added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Jul 25, 2025
@jnels124 jnels124 requested a review from nirbosl July 25, 2025 20:28
@lfdt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.69% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b230ec4) 36333 34033 93.67%
Head commit (9f78c08) 59764 (+23431) 36446 (+2413) 60.98% (-32.69%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11663) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 merged commit 72d066e into main Jul 28, 2025
31 of 33 checks passed
@jnels124 jnels124 deleted the jtn-11427-fixing-acceptance-test-non-zero-shard-realm branch July 28, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests fail with non-zero realm
4 participants