Skip to content

Conversation

xin-hedera
Copy link
Contributor

@xin-hedera xin-hedera commented Jul 23, 2025

Description:

This PR fixes the race condition in async java migrations:

  • Run async part of async java migrations after flyway migrate operation completes
  • Move performSynchronousSteps() and the conditional onSuccess() to post AFTER_MIGRATE_OPERATION_FINISH callback

Related issue(s):

Fixes #11643

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera requested a review from a team as a code owner July 23, 2025 03:24
@xin-hedera xin-hedera linked an issue Jul 23, 2025 that may be closed by this pull request
@xin-hedera xin-hedera self-assigned this Jul 23, 2025
@xin-hedera xin-hedera added this to the 0.135.0 milestone Jul 23, 2025
@xin-hedera xin-hedera added bug Type: Something isn't working importer Area: Importer labels Jul 23, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jul 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.73% (target: -1.00%) 86.96%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (12cf97b) 36294 34023 93.74%
Head commit (e2f12ef) 59731 (+23437) 36442 (+2419) 61.01% (-32.73%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11645) 23 20 86.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@xin-hedera xin-hedera merged commit e4dae0d into main Jul 23, 2025
31 of 33 checks passed
@xin-hedera xin-hedera deleted the 11643-race-condition-in-async-java-migrations branch July 23, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working importer Area: Importer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in async java migrations
4 participants