Skip to content

Conversation

xin-hedera
Copy link
Contributor

@xin-hedera xin-hedera commented Jul 18, 2025

Description:

This PR adds a workflow to test non-zero shard/realm

  • Add github workflow to test non-zero shard/realm
  • Don't fail-fast in jobs with matrix

Related issue(s):

Fixes #11540

Notes for reviewer:

There are tests failing in web3: https://github.com/hiero-ledger/hiero-mirror-node/actions/runs/16380493136?pr=11608

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera requested review from a team as code owners July 18, 2025 17:31
@xin-hedera xin-hedera linked an issue Jul 18, 2025 that may be closed by this pull request
@xin-hedera xin-hedera self-assigned this Jul 18, 2025
@xin-hedera xin-hedera added the enhancement Type: New feature label Jul 18, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jul 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@xin-hedera xin-hedera added the github actions Pull requests that update GitHub Actions code label Jul 18, 2025
@xin-hedera xin-hedera added this to the 0.135.0 milestone Jul 18, 2025
Copy link

codacy-production bot commented Jul 18, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.74% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dff919b) 36294 34024 93.75%
Head commit (e1c9e39) 59722 (+23428) 36434 (+2410) 61.01% (-32.74%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11608) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to quickly fix any of the test failures in this PR or do we need a separate ticket?

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera requested a review from a team as a code owner July 18, 2025 21:17
@xin-hedera xin-hedera requested a review from steven-sheehy July 18, 2025 21:30
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit 9dbfb49 into main Jul 21, 2025
32 of 33 checks passed
@xin-hedera xin-hedera deleted the 11540-create-github-action-to-run-tests-with-non-zero-shard-and-realm branch July 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature github actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Github Action to run tests with non-zero shard and realm
4 participants