Skip to content

Conversation

IvanKavaldzhiev
Copy link
Contributor

Description:
This PR bumps hedera.app to 0.64.0. The protobuf is kept at 0.63.5 since it wasn't updated at this release. It seems this does not interfere with bumping the hedera.app itself.

The PR also aligns some of the classpath overriden classes with the latest changes from hedera.app.

Related issue(s):

Fixes #11542

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@IvanKavaldzhiev IvanKavaldzhiev added this to the 0.135.0 milestone Jul 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Jul 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev requested a review from a team as a code owner July 14, 2025 13:10
@IvanKavaldzhiev IvanKavaldzhiev added dependencies Type: Pull requests that update a dependency file web3 Area: Web3 API labels Jul 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev requested a review from nirbosl July 14, 2025 13:10
@lfdt-bot
Copy link

lfdt-bot commented Jul 14, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.85% (target: -1.00%) 27.38%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a711e9) 36149 33927 93.85%
Head commit (868807a) 59719 (+23570) 36432 (+2505) 61.01% (-32.85%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11583) 84 23 27.38%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

kselveliev
kselveliev previously approved these changes Jul 14, 2025
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I see some problems with the release comparator workflow:

  • I see File changed: com/hedera/node/app/service/contract/impl/exec/processors/CustomMessageCallProcessor.java but no change to it in this PR
  • ConversionUtils was modified in this PR but it's not noted in the workflow as changing. Probably we need to add it to the whitelisted files in the workflow.
  • The workflow uses set -x which prints every command and is too verbose.

Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further research, think we need to remove CustomCallOperation from the release comparator workflow. But we can do that in a follow up.

@steven-sheehy steven-sheehy merged commit d6469ce into main Jul 16, 2025
32 of 35 checks passed
@steven-sheehy steven-sheehy deleted the 11542-bump-hedera-app-version branch July 16, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BLOCK_STREAM_INFO singleton
4 participants