-
Notifications
You must be signed in to change notification settings - Fork 128
Bump com.hedera.hashgraph:app to 0.64.0 #11583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I see some problems with the release comparator workflow:
- I see
File changed: com/hedera/node/app/service/contract/impl/exec/processors/CustomMessageCallProcessor.java
but no change to it in this PR ConversionUtils
was modified in this PR but it's not noted in the workflow as changing. Probably we need to add it to the whitelisted files in the workflow.- The workflow uses
set -x
which prints every command and is too verbose.
web3/src/main/java/org/hiero/mirror/web3/state/singleton/BlockStreamInfoSingleton.java
Outdated
Show resolved
Hide resolved
web3/src/main/java/org/hiero/mirror/web3/state/singleton/BlockStreamInfoSingleton.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…leases Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…e rest of the workflows in case of failure Signed-off-by: Ivan Kavaldzhiev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further research, think we need to remove CustomCallOperation from the release comparator workflow. But we can do that in a follow up.
Description:
This PR bumps hedera.app to 0.64.0. The protobuf is kept at 0.63.5 since it wasn't updated at this release. It seems this does not interfere with bumping the hedera.app itself.
The PR also aligns some of the classpath overriden classes with the latest changes from hedera.app.
Related issue(s):
Fixes #11542
Notes for reviewer:
Checklist