Skip to content

Conversation

kselveliev
Copy link
Contributor

@kselveliev kselveliev commented Jul 11, 2025

Description:
Fix bulk load storage slots.

Added a couple of integration tests that test concurrent calls to cover specific corner cases and also eviction corner case.

Fixes #11551

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev self-assigned this Jul 11, 2025
@kselveliev kselveliev added bug Type: Something isn't working web3 Area: Web3 API labels Jul 11, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jul 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 77b3d6c1 92.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (77b3d6c) Report Missing Report Missing Report Missing
Head commit (d0bcef5) 59695 36438 61.04%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11563) 14 13 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev requested a review from sdimitrov9 July 14, 2025 12:31
@kselveliev kselveliev marked this pull request as ready for review July 14, 2025 12:31
@kselveliev kselveliev requested a review from a team as a code owner July 14, 2025 12:31
@kselveliev kselveliev requested a review from steven-sheehy July 14, 2025 12:31
sdimitrov9
sdimitrov9 previously approved these changes Jul 14, 2025
@steven-sheehy steven-sheehy added this to the 0.135.0 milestone Jul 14, 2025
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 4a711e9 into main Jul 15, 2025
31 of 32 checks passed
@steven-sheehy steven-sheehy deleted the 11551-bulk-load-fixes branch July 15, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk slot loading returns inconsistent response
7 participants