Skip to content

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Jul 10, 2025

Description:

  • Fix grammar in log statement
  • Fix not cleaning up for errors on startup
  • Fix not verifying account is not created on all nodes before continuing

Related issue(s):

Fixes #11555

Notes for reviewer:

Since race condition is hard to reproduce, tested by manually throwing exceptions at different places.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added this to the 0.134.0 milestone Jul 10, 2025
@steven-sheehy steven-sheehy self-assigned this Jul 10, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner July 10, 2025 19:17
@steven-sheehy steven-sheehy requested a review from nirbosl July 10, 2025 19:17
@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Jul 10, 2025
@lfdt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-32.71% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (71e073e) 36182 33919 93.75%
Head commit (90c0aad) 59687 (+23505) 36433 (+2514) 61.04% (-32.71%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11556) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@steven-sheehy steven-sheehy merged commit 749917f into main Jul 10, 2025
45 of 51 checks passed
@steven-sheehy steven-sheehy deleted the 11555-acceptance-leakage branch July 10, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests can leak hbars for failures during startup
4 participants