Skip to content

Conversation

kselveliev
Copy link
Contributor

Description:
This Pr fixes all failing tests in ContractCallServiceHistoricalNegativeTest against modularized code.

ContractCallServiceHistoricalNegativeTest - test setup fixes

Related issue(s):

Fixes #10085

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…nst modularized code

Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev added enhancement Type: New feature web3 Area: Web3 API modularized evm labels Feb 13, 2025
@kselveliev kselveliev added this to the 0.124.0 milestone Feb 13, 2025
@kselveliev kselveliev self-assigned this Feb 13, 2025
@kselveliev kselveliev requested a review from a team as a code owner February 13, 2025 11:31
Copy link

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (f82ab41) to head (6d06466).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10373   +/-   ##
=========================================
  Coverage     92.18%   92.19%           
- Complexity     8094     8095    +1     
=========================================
  Files           988      988           
  Lines         33711    33711           
  Branches       4264     4264           
=========================================
+ Hits          31078    31081    +3     
+ Misses         1618     1615    -3     
  Partials       1015     1015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 9f89e38 into main Feb 13, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the 10085-contract-call-historical-negative branch February 13, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature modularized evm web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ContractCallServiceHistoricalNegativeTest test suite
3 participants