Fix nested calls historical tests for modularized #10349
Conversation
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
steven-sheehy,
nickeynikolovv,
bilyana-gospodinova and
filev94
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10349 +/- ##
=========================================
Coverage 92.21% 92.21%
Complexity 8025 8025
=========================================
Files 982 982
Lines 33507 33507
Branches 4226 4226
=========================================
Hits 30900 30900
Misses 1607 1607
Partials 1000 1000 ☔ View full report in Codecov by Sentry. |
| final var tokenMemo = "TestMemo"; | ||
| final var ownerEntity = accountEntityNoEvmAddressPersistHistorical( | ||
| Range.closedOpen(recordFileBeforeEvm34.getConsensusStart(), recordFileBeforeEvm34.getConsensusEnd())); | ||
| final var spenderPublicKey = "3a210398e17bcbd2926c4d8a31e32616b4754ac0a2fc71d7fb768e657db46202625f34"; |
There was a problem hiding this comment.
Can't we use the key that the domain builder would generate, if we set no value at all? Or at least the SPENDER* constants from ContractCallTestUtil?
There was a problem hiding this comment.
Refactored to use the spender constants.
There was a problem hiding this comment.
domainBuilder.key() does not work. We have a new method which it calls -> generateSecp256k1Key which is used to generated compressed public key. But it not always generates a valid key and the test becomes flaky (recoverAddressFromPubKey starts failing). This need to be fixed in another pr.
There was a problem hiding this comment.
Can you please open an issue to fix the domainBuilder.key() method then?
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
Description:
This PR fixes
ContractCallNestedCallsHistoricalTesttests against modularized code.Related issue(s):
Fixes #10081
Notes for reviewer:
Checklist