Include BlockHeader and RoundHeader for block root hash calculation #10322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
…ockheader-roundheader-to-block-item-merkle-tree-for-block-root-hash-calculation Signed-off-by: Xin Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10322 +/- ##
=========================================
Coverage 92.21% 92.21%
Complexity 8024 8024
=========================================
Files 982 982
Lines 33507 33508 +1
Branches 4226 4226
=========================================
+ Hits 30897 30900 +3
+ Misses 1609 1607 -2
Partials 1001 1001 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xin Li <[email protected]>
|
steven-sheehy
deleted the
10075-hip-1056-add-blockheader-roundheader-to-block-item-merkle-tree-for-block-root-hash-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the types of items included for block root hash calculation
Related issue(s):
Fixes #10075
Notes for reviewer:
Checklist