HIP-1056 Account BlockItem to RecordItem transformers #10314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Sawarkar <[email protected]>
steven-sheehy
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10314 +/- ##
============================================
- Coverage 92.19% 92.17% -0.02%
- Complexity 8096 8101 +5
============================================
Files 988 989 +1
Lines 33713 33729 +16
Branches 4263 4267 +4
============================================
+ Hits 31082 31091 +9
- Misses 1617 1620 +3
- Partials 1014 1018 +4 ☔ View full report in Codecov by Sentry. |
edwin-greene
reviewed
Feb 6, 2025
...mirror-importer/src/test/java/com/hedera/mirror/importer/parser/domain/BlockItemBuilder.java
Outdated
Show resolved
Hide resolved
xin-hedera
reviewed
Feb 6, 2025
...in/java/com/hedera/mirror/importer/downloader/block/transformer/CryptoCreateTransformer.java
Outdated
Show resolved
Hide resolved
…into HIP-1056-Account-BlockItem-to-RecordItem-transformers
steven-sheehy
added
importer
...in/java/com/hedera/mirror/importer/downloader/block/transformer/CryptoCreateTransformer.java
Show resolved
Hide resolved
...mirror-importer/src/test/java/com/hedera/mirror/importer/parser/domain/BlockItemBuilder.java
Outdated
Show resolved
Hide resolved
…into HIP-1056-Account-BlockItem-to-RecordItem-transformers
…apt the new accountId. Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
xin-hedera
requested changes
Feb 11, 2025
...in/java/com/hedera/mirror/importer/downloader/block/transformer/CryptoCreateTransformer.java
Outdated
Show resolved
Hide resolved
...in/java/com/hedera/mirror/importer/downloader/block/transformer/CryptoUpdateTransformer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsh Sawarkar <[email protected]>
xin-hedera
reviewed
Feb 12, 2025
...rter/src/test/java/com/hedera/mirror/importer/downloader/block/BlockFileTransformerTest.java
Outdated
Show resolved
Hide resolved
xin-hedera
reviewed
Feb 12, 2025
...rter/src/test/java/com/hedera/mirror/importer/downloader/block/BlockFileTransformerTest.java
Outdated
Show resolved
Hide resolved
xin-hedera
reviewed
Feb 12, 2025
...va/com/hedera/mirror/importer/downloader/block/transformer/AbstractBlockItemTransformer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
|
Looks like spotless formatting errors if you can run |
…into HIP-1056-Account-BlockItem-to-RecordItem-transformers
Signed-off-by: Harsh Sawarkar <[email protected]>
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added Account transformers and tests.
Related issue(s):
Fixes #10164
Notes for reviewer:
Checklist