-
Notifications
You must be signed in to change notification settings - Fork 127
Fix failing acceptance tests on mainnet for scheduled transactions #10312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
66610b9
to
d6c2b81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10312 +/- ##
=========================================
Coverage 92.19% 92.19%
Complexity 8006 8006
=========================================
Files 980 980
Lines 33444 33444
Branches 4218 4218
=========================================
+ Hits 30833 30834 +1
Misses 1610 1610
+ Partials 1001 1000 -1 ☔ View full report in Codecov by Sentry. |
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
Needs spotless apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… and added some additional checks Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
79b45f4
to
885f06e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR fixes a failing test on mainnet for scheduled transactions
Related issue(s):
Fixes #10290
Notes for reviewer:
Those delays only occur on mainnet so it is hard to reproduce them on testnet or previewnet
Checklist