Skip to content

Conversation

nickeynikolovv
Copy link
Contributor

Description:
This PR fixes a failing test on mainnet for scheduled transactions

  • Due to delay of transaction executions and responses handling increased the time for expiry from 8 to 16 seconds for the test that waits for expiration. Due to parallel test suites execution this increase will not cause a delay in the execution in general
  • The accounts creation was after the set of expiration time which was causing additional delay in the schedule execution
  • added additional check on "I wait until the schedule's expiration time" that waits until the transaction is executed and has a valid executedTimestamp

Related issue(s):

Fixes #10290

Notes for reviewer:
Those delays only occur on mainnet so it is hard to reproduce them on testnet or previewnet

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@nickeynikolovv nickeynikolovv added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Feb 6, 2025
@nickeynikolovv nickeynikolovv requested a review from a team February 6, 2025 13:47
@nickeynikolovv nickeynikolovv self-assigned this Feb 6, 2025
@nickeynikolovv nickeynikolovv force-pushed the fix-failing-scheduled-transactions-tests branch from 66610b9 to d6c2b81 Compare February 6, 2025 13:50
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (b94461e) to head (885f06e).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10312   +/-   ##
=========================================
  Coverage     92.19%   92.19%           
  Complexity     8006     8006           
=========================================
  Files           980      980           
  Lines         33444    33444           
  Branches       4218     4218           
=========================================
+ Hits          30833    30834    +1     
  Misses         1610     1610           
+ Partials       1001     1000    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kselveliev
Copy link
Contributor

Needs spotless apply

Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… and added some additional checks

Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv nickeynikolovv force-pushed the fix-failing-scheduled-transactions-tests branch from 79b45f4 to 885f06e Compare February 6, 2025 14:35
Copy link

sonarqubecloud bot commented Feb 6, 2025

@steven-sheehy steven-sheehy added this to the 0.124.0 milestone Feb 6, 2025
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 7b1fdce into main Feb 6, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the fix-failing-scheduled-transactions-tests branch February 6, 2025 15:47
@steven-sheehy steven-sheehy added bug Type: Something isn't working and removed enhancement Type: New feature labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule acceptance test fails
5 participants