Skip to content

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Feb 5, 2025

Description:

  • Change importer tests from running as mirror_node to mirror_importer db user
  • Fix some test regressions due to use of regular JdbcOperations

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Feb 5, 2025
@steven-sheehy steven-sheehy added this to the 0.124.0 milestone Feb 5, 2025
@steven-sheehy steven-sheehy self-assigned this Feb 5, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner February 5, 2025 18:48
@steven-sheehy steven-sheehy marked this pull request as draft February 5, 2025 18:57
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (883b425) to head (1d7806d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10309   +/-   ##
=========================================
  Coverage     92.18%   92.18%           
  Complexity     8005     8005           
=========================================
  Files           980      980           
  Lines         33444    33444           
  Branches       4218     4218           
=========================================
+ Hits          30830    30831    +1     
  Misses         1612     1612           
+ Partials       1002     1001    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steven Sheehy <[email protected]>
Copy link

sonarqubecloud bot commented Feb 5, 2025

@steven-sheehy steven-sheehy marked this pull request as ready for review February 5, 2025 21:12
Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit b94461e into main Feb 6, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the fix-db-user branch February 6, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants