Skip to content

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Feb 5, 2025

Description:

  • use owner jdbc template for node data migration

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added the bug Type: Something isn't working label Feb 5, 2025
@jnels124 jnels124 added this to the 0.124.0 milestone Feb 5, 2025
@jnels124 jnels124 requested a review from a team as a code owner February 5, 2025 01:14
Signed-off-by: Jesse Nelson <[email protected]>
edwin-greene
edwin-greene previously approved these changes Feb 5, 2025
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

xin-hedera
xin-hedera previously approved these changes Feb 5, 2025
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (8bb4bb3) to head (e82ce6e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10304      +/-   ##
============================================
- Coverage     92.18%   92.18%   -0.01%     
  Complexity     8005     8005              
============================================
  Files           980      980              
  Lines         33445    33444       -1     
  Branches       4218     4218              
============================================
- Hits          30832    30830       -2     
  Misses         1612     1612              
- Partials       1001     1002       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run spotlessApply

Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 dismissed stale reviews from xin-hedera and edwin-greene via e82ce6e February 5, 2025 15:04
Copy link

sonarqubecloud bot commented Feb 5, 2025

@jnels124 jnels124 merged commit 883b425 into main Feb 5, 2025
36 checks passed
@jnels124 jnels124 deleted the jtn-migration-fix branch February 5, 2025 15:28
jnels124 added a commit that referenced this pull request Feb 5, 2025
* use owner template

---------

Signed-off-by: Jesse Nelson <[email protected]>
(cherry picked from commit 883b425)
Signed-off-by: Jesse Nelson <[email protected]>
jnels124 added a commit that referenced this pull request Feb 5, 2025
Use owner template (#10304)

* use owner template

---------


(cherry picked from commit 883b425)

Signed-off-by: Jesse Nelson <[email protected]>
HarshsDev pushed a commit to HarshsDev/hedera-mirror-node that referenced this pull request Feb 6, 2025
* use owner template

---------

Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants