Add nullable check to estimateGas validation (#849) #852
+258
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nana-EC
requested review from
AlfredoG87,
ebadiere,
georgi-l95 and
lukelee-sl
Nana-EC
added
bug
Codecov ReportBase: 73.76% // Head: 73.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 73.76% 73.79% +0.02%
==========================================
Files 29 29
Lines 1776 1778 +2
Branches 324 325 +1
==========================================
+ Hits 1310 1312 +2
Misses 372 372
Partials 94 94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
georgi-l95
previously approved these changes
Jan 27, 2023
MM seems to send a null data param in the transaction object. We should not be validating in that case. - Expand trace logs to `eth.estimateGas()` to highlight param - Add nullable concept to validation object params and set data in transaction object to nullable - Expand `predefined.INVALID_PARAMETER` logs to make failures easier to troubleshoot - Updated and expanded tests to confirm `isValidAndNonNullableParam` logic - Updated RPC tests impacted by addition of value to the log Signed-off-by: georgi-l95 <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: georgi-l95 <[email protected]> Co-authored-by: georgi-l95 <[email protected]>
Nana-EC
force-pushed
the
836-estimategas-validation-fix
branch
from
d424974 to
deda781
Compare
georgi-l95
previously approved these changes
Jan 27, 2023
Signed-off-by: georgi-l95 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick of #849 to main for consistency
MM seems to send a null data param in the transaction object. We should not be validating in that case.
eth.estimateGas()to highlight parampredefined.INVALID_PARAMETERlogs to make failures easier to troubleshootisValidAndNonNullableParamlogicSigned-off-by: georgi-l95 [email protected]
Signed-off-by: Nana Essilfie-Conduah [email protected]
Signed-off-by: georgi-l95 [email protected]
Co-authored-by: georgi-l95 [email protected]
Related issue(s):
Addresses #836
Notes for reviewer:
Checklist