Handle empty state_changes array in contract details #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
requested review from
Nana-EC,
david-bakin-sl,
dimitrovmaksim and
shemnon
Nana-EC
reviewed
Dec 2, 2022
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
LG, offered a simplification
Signed-off-by: lukelee-sl <[email protected]>
Codecov ReportBase: 71.08% // Head: 71.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 71.08% 71.21% +0.13%
==========================================
Files 16 16
Lines 1207 1209 +2
Branches 219 220 +1
==========================================
+ Hits 858 861 +3
+ Misses 287 286 -1
Partials 62 62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM |
Signed-off-by: lukelee-sl <[email protected]> add utility function for brevity and clarity Signed-off-by: lukelee-sl <[email protected]> remove unused import Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
force-pushed
the
732-getStorageAt-empty-array
branch
from
92b8ac6 to
36a62fe
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lukelee-sl
added a commit
that referenced
this pull request
Dec 2, 2022
* Handle empty state_change array in contract details Signed-off-by: lukelee-sl <[email protected]> * update errors to use predefined errors Signed-off-by: lukelee-sl <[email protected]> * remove redundant null check Signed-off-by: lukelee-sl <[email protected]> add utility function for brevity and clarity Signed-off-by: lukelee-sl <[email protected]> remove unused import Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
added a commit
that referenced
this pull request
Dec 2, 2022
* Handle empty state_change array in contract details Signed-off-by: lukelee-sl <[email protected]> * update errors to use predefined errors Signed-off-by: lukelee-sl <[email protected]> * remove redundant null check Signed-off-by: lukelee-sl <[email protected]> add utility function for brevity and clarity Signed-off-by: lukelee-sl <[email protected]> remove unused import Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lukelee-sl [email protected]
Handle the case when the state_changes field returned as an empty array.
Fixes #732