-
Notifications
You must be signed in to change notification settings - Fork 90
feat: encapsulate ENABLE_TX_POOL flag in TransactionPoolService
#4581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: encapsulate ENABLE_TX_POOL flag in TransactionPoolService
#4581
Conversation
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
ENABLE_TX_POOL flag in TransactionServiceENABLE_TX_POOL flag in TransactionPoolService
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of items
packages/relay/src/lib/services/ethService/accountService/AccountService.ts
Show resolved
Hide resolved
packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts
Outdated
Show resolved
Hide resolved
konstantinabl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That was my vision! Simple, effective, and not repetitive! Great work!
…saction-service # Conflicts: # packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts # packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4581 +/- ##
==========================================
+ Coverage 95.37% 95.42% +0.04%
==========================================
Files 128 128
Lines 20647 20658 +11
Branches 1759 1762 +3
==========================================
+ Hits 19692 19712 +20
+ Misses 936 927 -9
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
Currently, the ENABLE_TX_POOL flag is used in AccountService, which is not ideal, since the TransactionPoolService should take care of its own flag
Related issue(s)
Fixes #4503
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist