Skip to content

Conversation

@natanasow
Copy link
Member

Description

Currently, the ENABLE_TX_POOL flag is used in AccountService, which is not ideal, since the TransactionPoolService should take care of its own flag

Related issue(s)

Fixes #4503

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@natanasow natanasow added this to the 0.73.0 milestone Nov 6, 2025
@natanasow natanasow self-assigned this Nov 6, 2025
@natanasow natanasow added the enhancement New feature or request label Nov 6, 2025
Signed-off-by: nikolay <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Test Results

 20 files  ±0  269 suites  ±0   21m 30s ⏱️ -35s
778 tests ±0  774 ✅ +1  4 💤 ±0  0 ❌  - 1 
794 runs  ±0  790 ✅ +1  4 💤 ±0  0 ❌  - 1 

Results for commit 0414f7f. ± Comparison against base commit 4ea1929.

♻️ This comment has been updated with latest results.

@natanasow natanasow marked this pull request as ready for review November 6, 2025 14:43
@natanasow natanasow requested review from a team as code owners November 6, 2025 14:43
@natanasow natanasow changed the title feat: encapsulate ENABLE_TX_POOL flag in TransactionService feat: encapsulate ENABLE_TX_POOL flag in TransactionPoolService Nov 6, 2025
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of items

Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested a review from simzzz November 7, 2025 07:29
simzzz
simzzz previously approved these changes Nov 7, 2025
@natanasow natanasow requested a review from quiet-node November 7, 2025 14:07
Copy link
Contributor

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested a review from simzzz November 10, 2025 11:59
simzzz
simzzz previously approved these changes Nov 10, 2025
quiet-node
quiet-node previously approved these changes Nov 10, 2025
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That was my vision! Simple, effective, and not repetitive! Great work!

…saction-service

# Conflicts:
#	packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts
#	packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts
@natanasow natanasow dismissed stale reviews from quiet-node and simzzz via 0414f7f November 10, 2025 16:14
@natanasow natanasow requested a review from simzzz November 10, 2025 16:14
@natanasow natanasow requested a review from quiet-node November 10, 2025 16:14
@natanasow natanasow merged commit 7bf6405 into main Nov 10, 2025
65 of 67 checks passed
@natanasow natanasow deleted the 4503-encapsulate-enable-tx-pool-flat-in-transaction-service branch November 10, 2025 17:58
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4581      +/-   ##
==========================================
+ Coverage   95.37%   95.42%   +0.04%     
==========================================
  Files         128      128              
  Lines       20647    20658      +11     
  Branches     1759     1762       +3     
==========================================
+ Hits        19692    19712      +20     
+ Misses        936      927       -9     
  Partials       19       19              
Flag Coverage Δ
config-service 98.81% <ø> (ø)
relay 90.86% <100.00%> (+<0.01%) ⬆️
server 88.85% <ø> (ø)
ws-server 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/precheck.ts 98.68% <100.00%> (-0.01%) ⬇️
...rvices/ethService/accountService/AccountService.ts 96.53% <100.00%> (ø)
...thService/transactionService/TransactionService.ts 98.85% <100.00%> (+1.12%) ⬆️
...s/transactionPoolService/transactionPoolService.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encapsulate ENABLE_TX_POOL flag in TransactionPoolService

5 participants