feat: adds RLP hex txn storage to tx pool service #4521

simzzz · 2025-10-27T11:20:39Z

Description

Currently, we're saving only the transaction hash in the transaction pool storage but for txpool_* related methods, we need the entire transaction object. This PR adds storage of the entire txn as an RLP hex in both LRU and Redis.

Related issue(s)

Fixes #4500

quiet-node · 2025-10-27T17:33:24Z

Haven’t gone through this in depth yet, but it looks like we’re changing the design of the txPool implementation. To avoid adding new changes on top of moving parts, I suggest holding off on merging this into the feature branch until the feature branch is finalized and merged into main first.

github-actions · 2025-10-29T11:50:16Z

Test Results

20 files ±0 269 suites ±0 30m 27s ⏱️ + 8m 52s
779 tests +1 772 ✅ ±0 4 💤 ±0 3 ❌ +1
794 runs ±0 787 ✅ - 1 4 💤 ±0 3 ❌ +1

For more details on these failures, see this check.

Results for commit 5928e28. ± Comparison against base commit 8a7783c.

♻️ This comment has been updated with latest results.

konstantinabl

A comment and a few questions

packages/config-service/src/services/globalConfig.ts

packages/relay/src/lib/services/transactionPoolService/LocalPendingTransactionStorage.ts

quiet-node

I think we should have a sync session to discuss this as a team

packages/relay/src/lib/services/transactionPoolService/LocalPendingTransactionStorage.ts

packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts

Signed-off-by: Simeon Nakov <[email protected]>

quiet-node

Left some comments and questions

packages/config-service/src/services/globalConfig.ts

packages/relay/src/lib/services/transactionPoolService/LocalPendingTransactionStorage.ts

packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts

quiet-node · 2025-11-04T17:51:14Z

packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts

+  /**
+   * Key for the global pending transactions index.
+   */
+  private readonly globalIndexKey = 'txpool:pending:txns';


Should we make this a dependant of keyPrefix?

Suggested change

private readonly globalIndexKey = 'txpool:pending:txns';

private readonly globalIndexKey = `${keyPrefix}txns`;

Also should we make it more clear? globalIndexKey is quite confusing. Could it be globalPendingTxsKey or something? and the value could be ${keyPrefix}global?

Signed-off-by: Simeon Nakov <[email protected]>

quiet-node · 2025-11-05T19:23:07Z

packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts

    const key = this.keyFor(address);
-
-    await this.redisClient.sRem(key, txHash);
+    await this.redisClient.multi().sRem(key, rlpHex).sRem(this.globalIndexKey, rlpHex).execAsPipeline();


Why do we have .execAsPipeline() here but can't be .exec() like in addToList()?

Signed-off-by: Simeon Nakov <[email protected]>

packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts

quiet-node

Two last things and I believe I'm ready to approve

packages/config-service/src/services/globalConfig.ts

packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts

packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts

Signed-off-by: Simeon Nakov <[email protected]>

quiet-node

Coolio LGTM!

konstantinabl · 2025-11-07T14:20:47Z

packages/relay/src/lib/services/transactionPoolService/transactionPoolService.ts

-      throw new Error('Transaction hash is required for storage');
-    }
+    const rlpHex = tx.serialized;
+    await this.storage.addToList(addressLowerCased, rlpHex);


Do you think we have sufficient error handling? On the lower level we have error logging when an error is detected on redis level, but we do not throw any errors. Just wondering if we might need error handling or at least logging on error, currently we use logger.debug im just not sure it will log correctly

Signed-off-by: Simeon Nakov <[email protected]>

codecov · 2025-11-08T00:14:23Z

Codecov Report

❌ Patch coverage is 79.67914% with 38 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/relay/src/lib/types/transactionPool.ts	0.00%	38 Missing ⚠️

@@            Coverage Diff             @@
##             main    #4521      +/-   ##
==========================================
- Coverage   95.52%   95.40%   -0.12%     
==========================================
  Files         127      127              
  Lines       20493    20624     +131     
  Branches     1760     1763       +3     
==========================================
+ Hits        19576    19677     +101     
- Misses        898      928      +30     
  Partials       19       19

Flag	Coverage Δ
config-service	`98.81% <100.00%> (ø)`
relay	`90.83% <79.12%> (-0.12%)`	⬇️
server	`88.85% <ø> (ø)`
ws-server	`98.04% <ø> (+1.36%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ckages/config-service/src/services/globalConfig.ts	`100.00% <100.00%> (ø)`
...thService/transactionService/TransactionService.ts	`98.86% <100.00%> (ø)`
...ctionPoolService/LocalPendingTransactionStorage.ts	`100.00% <100.00%> (ø)`
...ctionPoolService/RedisPendingTransactionStorage.ts	`100.00% <100.00%> (ø)`
...s/transactionPoolService/transactionPoolService.ts	`100.00% <100.00%> (ø)`
packages/relay/src/lib/types/transactionPool.ts	`0.00% <0.00%> (ø)`

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

simzzz self-assigned this Oct 27, 2025

simzzz marked this pull request as ready for review October 27, 2025 11:21

simzzz requested review from a team as code owners October 27, 2025 11:21

simzzz requested a review from acuarica October 27, 2025 11:21

simzzz marked this pull request as draft October 28, 2025 12:52

simzzz marked this pull request as ready for review October 28, 2025 12:52

quiet-node force-pushed the feat/transaction-pool branch from aab2f1e to f908c27 Compare October 29, 2025 03:54

Base automatically changed from feat/transaction-pool to main October 29, 2025 09:11

simzzz force-pushed the 4500-save-rlp-decoded-txn branch from e57963a to d2f61af Compare October 29, 2025 11:45

simzzz added this to the 0.74.0 milestone Oct 29, 2025

simzzz added the enhancement New feature or request label Oct 29, 2025

konstantinabl requested changes Oct 30, 2025

View reviewed changes

simzzz requested review from a team and konstantinabl October 30, 2025 13:41

quiet-node reviewed Oct 30, 2025

View reviewed changes

simzzz added 7 commits November 4, 2025 11:23

feat: adds RLP hex txn storage to tx pool service

6c61ec3

Signed-off-by: Simeon Nakov <[email protected]>

feat: unified save/remove calls into one multi in redis

c4bc163

Signed-off-by: Simeon Nakov <[email protected]>

add test coverage

c164f01

Signed-off-by: Simeon Nakov <[email protected]>

addressed comments

aa73992

Signed-off-by: Simeon Nakov <[email protected]>

added new env vars to example and docs

0b55f9b

Signed-off-by: Simeon Nakov <[email protected]>

simplified code

e73e87d

Signed-off-by: Simeon Nakov <[email protected]>

fixed failing tests

71c4d1b

Signed-off-by: Simeon Nakov <[email protected]>

simzzz force-pushed the 4500-save-rlp-decoded-txn branch from 2b4d890 to 71c4d1b Compare November 4, 2025 12:25

simzzz requested review from Ferparishuertas, natanasow and quiet-node November 4, 2025 12:59

quiet-node reviewed Nov 4, 2025

View reviewed changes

addressed comments

816ce42

Signed-off-by: Simeon Nakov <[email protected]>

simzzz requested a review from quiet-node November 5, 2025 15:36

quiet-node reviewed Nov 5, 2025

View reviewed changes

simzzz added 2 commits November 6, 2025 11:03

removed tx pool storage TTL from constants

c853d3d

Signed-off-by: Simeon Nakov <[email protected]>

removed unused env var from configuration.md

e81b3a4

Signed-off-by: Simeon Nakov <[email protected]>

konstantinabl reviewed Nov 6, 2025

View reviewed changes

packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts Show resolved Hide resolved

quiet-node reviewed Nov 6, 2025

View reviewed changes

addressed comments

f35301e

Signed-off-by: Simeon Nakov <[email protected]>

simzzz requested a review from quiet-node November 6, 2025 15:52

quiet-node previously approved these changes Nov 6, 2025

View reviewed changes

natanasow previously approved these changes Nov 7, 2025

View reviewed changes

simzzz requested a review from konstantinabl November 7, 2025 10:07

Merge branch 'main' into 4500-save-rlp-decoded-txn

d698d1b

konstantinabl reviewed Nov 7, 2025

View reviewed changes

wrapped redis operations in try/catch in service

5928e28

Signed-off-by: Simeon Nakov <[email protected]>

simzzz dismissed stale reviews from natanasow and quiet-node via 5928e28 November 7, 2025 17:54

	private readonly globalIndexKey = 'txpool:pending:txns';
	private readonly globalIndexKey = `${keyPrefix}txns`;

feat: adds RLP hex txn storage to tx pool service #4521

Are you sure you want to change the base?

feat: adds RLP hex txn storage to tx pool service #4521

Conversation

simzzz commented Oct 27, 2025

Description

Related issue(s)

Uh oh!

quiet-node commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

konstantinabl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

quiet-node left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

quiet-node left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

quiet-node Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

simzzz Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

quiet-node Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

simzzz Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

quiet-node left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

quiet-node left a comment

Choose a reason for hiding this comment

Uh oh!

konstantinabl Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 8, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Oct 29, 2025 •

edited

Loading