feat: add ENABLE_TX_POOL feature flag
#4447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
simzzz
reviewed
Oct 6, 2025
| ); | ||
| const signerNonce = | ||
| mirrorAccountInfo.ethereum_nonce + ConfigService.get('ENABLE_TX_POOL') | ||
| ? await this.transactionPoolService.getPendingCount(parsedTx.from!) |
Contributor
There was a problem hiding this comment.
nit: maybe we could add a separate constant for pending count to make it more readable
Member
Author
There was a problem hiding this comment.
It will be computed each time, which will be a waste of resources if the ENABLE_TX_POOL is false. Or am I wrong?
Signed-off-by: Konstantina Blazhukova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To enable the new transaction pool feature a ENABLE_TX_POOL will be used. If the flag is enabled the new nonce precheck will be used and the getTransactionCount with block tag pending will returng the MN nonce + the pending transactions list length instead of just returning the MN nonce. Also, the save and removal of transactions in the sendRawTransaction method won't happen.
Related issue(s)
Fixes #4395
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist