Skip to content

Conversation

@natanasow
Copy link
Member

@natanasow natanasow commented Oct 3, 2025

Description

Currently, the nonce precheck uses a simple condition to check the sent nonce with the nonce we receive from the MN account info. Now this precheck needs to be updated to check the nonce not only from the MN account info but also account for the pending transactions list for the user.

Related issue(s)

Fixes #4394

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

konstantinabl and others added 2 commits October 2, 2025 16:11
@natanasow natanasow added this to the 0.73.0 milestone Oct 3, 2025
@natanasow natanasow self-assigned this Oct 3, 2025
@natanasow natanasow added the enhancement New feature or request label Oct 3, 2025
@natanasow natanasow changed the base branch from main to 4393-update-sendrawtransaction-methods October 3, 2025 06:30
@natanasow natanasow marked this pull request as ready for review October 3, 2025 08:47
@natanasow natanasow requested review from a team as code owners October 3, 2025 08:47
@natanasow natanasow requested a review from acuarica October 3, 2025 08:47
Base automatically changed from 4393-update-sendrawtransaction-methods to feat/transaction-pool October 3, 2025 12:42
…method

# Conflicts:
#	packages/relay/src/lib/eth.ts
#	packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts
@natanasow natanasow merged commit 1816a32 into feat/transaction-pool Oct 3, 2025
5 checks passed
@natanasow natanasow deleted the 4394-update-nonce-precheck-method branch October 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nonce precheck method

4 participants