Fix indexing issue in wireframe plotting #560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array meant to store indices in the `make_plot_2d` method of the ToroidalWireframe class is now initialized explicitly as an integer array. The aim is to prevent a bug from occurring in some tests with one of these arrays that appears to be due to a floating point error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve issue #553 in which one of the tests failed on a wireframe example due to an apparent indexing error. I wasn't able to reproduce the error on my machine, but I believe this arises from an issue in querying an array with an index that was converted from a floating point value. The code has been modified to avoid the float-integer conversion that gave rise to the error.