Use ubunut 24.04 in place of other ubuntu runners #486

mbkumar · 2025-04-25T14:32:10Z

No description provided.

mbkumar · 2025-05-05T15:15:50Z

Putting the failing tests from CI here for future reference.

======================================================================
ERROR: test_boozer_surface_optimisation_convergence (geo.test_boozersurface.BoozerSurfaceTests) (surfacetype='SurfaceXYZTensorFourier', stellsym=True, optimize_G=True, second_stage='newton_exact', get_data=<function get_ncsx_data at 0x7f6aea688b80>, vectorize=False)
Test to verify the various optimization algorithms that compute
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 238, in test_boozer_surface_optimisation_convergence
    self.subtest_boozer_surface_optimisation_convergence(
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 304, in subtest_boozer_surface_optimisation_convergence
    res = boozer_surface.minimize_boozer_exact_constraints_newton(
  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/simsopt/geo/boozersurface.py", line 641, in minimize_boozer_exact_constraints_newton
    dx = np.linalg.solve(A, b)
  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/numpy/linalg/_linalg.py", line 410, in solve
    r = gufunc(a, b, signature=signature)
  File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/numpy/linalg/_linalg.py", line 104, in _raise_linalgerror_singular
    raise LinAlgError("Singular matrix")
numpy.linalg.LinAlgError: Singular matrix

======================================================================
FAIL: test_boozer_surface_optimisation_convergence (geo.test_boozersurface.BoozerSurfaceTests) (surfacetype='SurfaceXYZTensorFourier', stellsym=True, optimize_G=True, second_stage='newton_exact', get_data=<function get_hsx_data at 0x7f6aea688dc0>, vectorize=False)
Test to verify the various optimization algorithms that compute
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 238, in test_boozer_surface_optimisation_convergence
    self.subtest_boozer_surface_optimisation_convergence(
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 311, in subtest_boozer_surface_optimisation_convergence
    assert res['success']
AssertionError

======================================================================
FAIL: test_boozer_surface_optimisation_convergence (geo.test_boozersurface.BoozerSurfaceTests) (surfacetype='SurfaceXYZTensorFourier', stellsym=True, optimize_G=True, second_stage='newton', get_data=<function get_ncsx_data at 0x7f6aea688b80>, vectorize=False)
Test to verify the various optimization algorithms that compute
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 238, in test_boozer_surface_optimisation_convergence
    self.subtest_boozer_surface_optimisation_convergence(
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 311, in subtest_boozer_surface_optimisation_convergence
    assert res['success']
AssertionError

======================================================================
FAIL: test_boozer_surface_optimisation_convergence (geo.test_boozersurface.BoozerSurfaceTests) (surfacetype='SurfaceXYZTensorFourier', stellsym=True, optimize_G=True, second_stage='newton', get_data=<function get_giuliani_data at 0x7f6aea688af0>, vectorize=False)
Test to verify the various optimization algorithms that compute
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 238, in test_boozer_surface_optimisation_convergence
    self.subtest_boozer_surface_optimisation_convergence(
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 311, in subtest_boozer_surface_optimisation_convergence
    assert res['success']
AssertionError

======================================================================
FAIL: test_boozer_surface_optimisation_convergence (geo.test_boozersurface.BoozerSurfaceTests) (surfacetype='SurfaceXYZFourier', stellsym=True, optimize_G=False, second_stage='ls', get_data=<function get_ncsx_data at 0x7f6aea688b80>, vectorize=False)
Test to verify the various optimization algorithms that compute
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 238, in test_boozer_surface_optimisation_convergence
    self.subtest_boozer_surface_optimisation_convergence(
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 312, in subtest_boozer_surface_optimisation_convergence
    assert not boozer_surface.surface.is_self_intersecting(thetas=100)
AssertionError

======================================================================
FAIL: test_convergence_cpp_and_notcpp_same (geo.test_boozersurface.BoozerSurfaceTests)
This unit test verifies that that the cpp and not cpp implementations converge to
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 392, in test_convergence_cpp_and_notcpp_same
    x_nonvec = self.subtest_convergence_cpp_and_notcpp_same(False)
  File "/home/runner/work/simsopt/simsopt/tests/geo/test_boozersurface.py", line 426, in subtest_convergence_cpp_and_notcpp_same
    assert res['success']
AssertionError

akaptano · 2025-05-12T14:33:18Z

Happy to get this over the finish line, but what is the advantage of this change?

Seems like it addresses (#467) although I don't think there is understanding still of why different ubuntu versions break certain tests in the code?

mbkumar · 2025-05-12T14:41:15Z

Happy to get this over the finish line, but what is the advantage of this change?

No advantage, but a necessity. ubuntu-latest points to ubuntu 24.04 on Github runners where the CI was failing. On CI, we changed the runners back to 22.04. But we have to transition to Ubuntu 24.04 eventually when 22.04 reaches EOL in 2027. Many will install 24.04 even before that and we want to have no test failures.

…s. Fixed the linting issue.

codecov · 2025-05-12T15:47:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (706cb1d) to head (f63dfc8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          82       82           
  Lines       16015    16015           
=======================================
  Hits        14738    14738           
  Misses       1277     1277

Flag	Coverage Δ
unittests	`92.02% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

andrewgiuliani · 2025-05-12T19:59:14Z

@mbkumar weren't the failing tests happening on Ubuntu 24.04? why would forcing 24.04 fix the issue?

mbkumar · 2025-05-12T20:07:52Z

We are not forcing 24.04 on people. It is the other way, people want to run simsopt on 24.04. So we need to resolve the issues. This PR is to address that.

…

On Mon, May 12, 2025 at 3:59 PM Andrew Giuliani ***@***.***> wrote: *andrewgiuliani* left a comment (hiddenSymmetries/simsopt#486) <#486 (comment)> @mbkumar <https://github.com/mbkumar> weren't the failing tests happening on Ubuntu 24.04? why would forcing 24.04 fix the issue? — Reply to this email directly, view it on GitHub <#486 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA62VEBGAP3GRDUYKGEZGW326D4SPAVCNFSM6AAAAAB33ZHE2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZTHAZDCNRVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

mbkumar added 2 commits April 25, 2025 07:59

Use ubunut 24.04 in place of other ubuntu runners

031cb0b

Update test_boozersurface.py

6fce511

mbkumar mentioned this pull request May 5, 2025

test_boozer_surface_optimisation_convergence failing for Ubuntu 24.04 #489

Open

mbkumar assigned mbkumar and akaptano May 12, 2025

Fixed the test_flux_through_disk test by adding more quadrature point…

4f4d8c1

…s. Fixed the linting issue.

Merge branch 'master' into ubuntu24

f63dfc8

mishapadidar requested a review from andrewgiuliani June 12, 2025 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Use ubunut 24.04 in place of other ubuntu runners #486

Use ubunut 24.04 in place of other ubuntu runners #486

Uh oh!

mbkumar commented Apr 25, 2025

Uh oh!

mbkumar commented May 5, 2025

Uh oh!

akaptano commented May 12, 2025 •

edited

Loading

Uh oh!

mbkumar commented May 12, 2025

Uh oh!

codecov bot commented May 12, 2025 •

edited

Loading

Uh oh!

andrewgiuliani commented May 12, 2025

Uh oh!

mbkumar commented May 12, 2025 via email •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Use ubunut 24.04 in place of other ubuntu runners #486

Are you sure you want to change the base?

Use ubunut 24.04 in place of other ubuntu runners #486

Uh oh!

Conversation

mbkumar commented Apr 25, 2025

Uh oh!

mbkumar commented May 5, 2025

Uh oh!

akaptano commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbkumar commented May 12, 2025

Uh oh!

codecov bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andrewgiuliani commented May 12, 2025

Uh oh!

mbkumar commented May 12, 2025 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akaptano commented May 12, 2025 •

edited

Loading

codecov bot commented May 12, 2025 •

edited

Loading

mbkumar commented May 12, 2025 via email •

edited

Loading