Skip to content

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HV-2018

I guess we never anticipated that the validation constraints will be only defined on an interface and that interface is passed to the validateValue().
What currently happens is that beanMetaData.getClassHierarchy() is empty and once we want to validate things we never get into this loop:

// evaluating the constraints of a bean per class in hierarchy, this is necessary to detect potential default group re-definitions
for ( Class<? super U> clazz : beanMetaData.getClassHierarchy() ) {
BeanMetaData<? super U> hostingBeanMetaData = beanMetaDataManager.getBeanMetaData( clazz );
boolean defaultGroupSequenceIsRedefined = hostingBeanMetaData.isDefaultGroupSequenceRedefined();

Which means we actually do not evaluate any constraints...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.


@marko-bekhta
Copy link
Member Author

@gsmet I'll let you take a look at this one once you have time. I think the patch makes sense, but maybe I'm missing something.. and since the filtering part should only happen once when the metadata is created it shouldn't cause issues because of those additional allocations to create filter instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant