HV-2018 Keep the interface if it is the hierarchy root #1399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HV-2018
I guess we never anticipated that the validation constraints will be only defined on an interface and that interface is passed to the
validateValue()
.What currently happens is that
beanMetaData.getClassHierarchy()
is empty and once we want to validate things we never get into this loop:hibernate-validator/engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
Lines 458 to 462 in bb61299
Which means we actually do not evaluate any constraints...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.