Revert Vert.x to 4.4 #1835
Merged
Revert Vert.x to 4.4 #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 163eee7.
Requires Vert.x 4.5
It doesn't work with Vert.x 4.4 and Hibernate ORM >= 6.2.14.Final.
Everything works fine with Vert.x 4.5
Error stacktrace:
``
Caused by:
org.opentest4j.AssertionFailedError: expected: <New Parent> but was: <NEW PARENT>
at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1142)
at app//org.hibernate.reactive.CascadeTest.lambda$testCascade$26(CascadeTest.java:136)
```
DavideD
force-pushed
the
1834-Revert-vert.x
branch
from
f09c825 to
3678c22
Compare
yrodiere
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I've disabled
CascadeTest#testQuerybecause fails the build with the Hibernate ORM snapshotsFix #1834