refactor(web): track post attachment store #5827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hey-mainnet with
|
| Latest commit: |
ab62dda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c99e567f.hey-mainnet.pages.dev |
| Branch Preview URL: | https://hey-refactor-usepostattachme.hey-mainnet.pages.dev |
Deploying hey-testnet with
|
| Latest commit: |
ab62dda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2880763c.hey-testnet.pages.dev |
| Branch Preview URL: | https://hey-refactor-usepostattachme.hey-testnet.pages.dev |
Deploying hey-staging with
|
| Latest commit: |
ab62dda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c4310ea.hey-staging.pages.dev |
| Branch Preview URL: | https://hey-refactor-usepostattachme.hey-staging.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the post attachment store to use a tracked Zustand store for more precise state subscriptions. Key changes include replacing the base create store with createTrackedStore and updating all consumer hooks and components to call usePostAttachmentStore() without inline selectors.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/store/non-persisted/post/usePostAttachmentStore.ts | Swapped create for createTrackedStore and updated export |
| apps/web/src/hooks/useUploadAttachments.tsx | Removed selector argument from usePostAttachmentStore() |
| apps/web/src/hooks/usePostMetadata.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/hooks/prosekit/usePaste.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Shared/GlobalModals.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Post/Actions/Menu/Edit.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/NewPublication.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/NewAttachments.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/LinkPreviews.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/ChooseThumbnail.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/Actions/LivestreamSettings/index.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/Actions/Gif/index.tsx | Updated store hook call to usePostAttachmentStore() |
| apps/web/src/components/Composer/Actions/Attachment.tsx | Updated store hook call to usePostAttachmentStore() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.