-
-
Notifications
You must be signed in to change notification settings - Fork 5k
chore(deps): update eslint #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to testgit clone -b eslint https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
This comment was marked as outdated.
This comment was marked as outdated.
|
@uiolee |
|
about "n/no-missing-import", full path is required. Maybe we need change our code style. |
Pull Request Test Coverage Report for Build 14560644494Details
💛 - Coveralls |
Co-authored-by: yoshinorin <[email protected]> Signed-off-by: Mimi <[email protected]>
Signed-off-by: D-Sketon <[email protected]>
|
I made some updates, ESLint no longer throws errors now. |
How about adding a const config = require('eslint-config-hexo/ts');
module.exports = [
...config,
{
'rules': {
'@typescript-eslint/no-explicit-any': 0,
'@typescript-eslint/no-var-requires': 0,
'@typescript-eslint/no-require-imports': 0,
'n/no-missing-require': 0,
'n/no-missing-import': 0,
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "argsIgnorePattern": "^_"
+ }
+ ]
}
}
];- // eslint-disable-next-line @typescript-eslint/no-unused-vars
- run(context, args, body, callback) {
+ run(context, args, _body, _callback) {
return this._run(context, args, '');
} |
yoshinorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀


What does it do?
See hexojs/eslint-config-hexo#64
Screenshots
Pull request tasks