Skip to content

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 4, 2019

What does it do?

  • IDN now always output in unicode, regardless the source is unicode or punycode, after Leave IDN intact in permalink hexo-util#116
  • category and tag uses chinese word because diacritic is escaped by default (á -> a); once escaped, it's not percent-encoded anymore so couldn't cover the url encoding test.
  • expected result now uses dynamic result of encodeURL()/full_url_for() instead of hardcoded, this allows compatibility with any changes in encodeURL().

How to test

git clone -b hexo-util_1.5 https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.144% when pulling ef0a966 on curbengh:hexo-util_1.5 into 878cf1b on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.144% when pulling ef0a966 on curbengh:hexo-util_1.5 into 878cf1b on hexojs:master.

@curbengh curbengh requested a review from a team November 4, 2019 11:44
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all checks have passed, I think it is good to go then.

@curbengh curbengh merged commit 77f3e21 into hexojs:master Nov 5, 2019
@curbengh curbengh deleted the hexo-util_1.5 branch November 5, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants