Skip to content

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Oct 18, 2019

What does it do?

Fix #3777
BREAKING CHANGE: requires Node >= 8.10

How to test

git clone -b meta-gen-fix https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh requested a review from a team October 18, 2019 11:10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.267% when pulling 4f7373b on curbengh:meta-gen-fix into 5d94690 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Oct 18, 2019

Since this fix is not so emergency, we can include this in v4.1 along with other changes.

@curbengh curbengh added this to the v4.1.0 milestone Oct 19, 2019
@curbengh curbengh merged commit 0670d54 into hexojs:master Oct 19, 2019
@curbengh curbengh deleted the meta-gen-fix branch October 19, 2019 00:15
@curbengh
Copy link
Contributor Author

I just cleared netlify cache of Hexo.io to include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta_generator tag is not added to <head>
3 participants