Skip to content

if post.title is empty, set it to post.slug #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

if post.title is empty, set it to post.slug #3672

merged 1 commit into from
Aug 30, 2019

Conversation

rupertqin
Copy link
Contributor

@rupertqin rupertqin commented Aug 16, 2019 •
edited by curbengh
Loading

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.156% when pulling af5e7b4 on rupertqin:master into 3176fe0 on hexojs:master.

curbengh
curbengh approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works in an empty file.

@curbengh curbengh added this to the v4.0.0 milestone Aug 21, 2019
@curbengh curbengh mentioned this pull request Aug 21, 2019
Closed
@curbengh curbengh requested a review from a team August 30, 2019 06:27
yoshinorin
yoshinorin approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupertqin Thank you for your contribution :)

@yoshinorin yoshinorin merged commit f57f700 into hexojs:master Aug 30, 2019
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
@curbengh
docs(front-matter): post.title defaults to filename if empty
fbf63c1 
hexojs/hexo#3672
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
@curbengh
docs(front-matter): post.title defaults to filename if empty
3d57cc1 
hexojs/hexo#3672
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
@curbengh
docs(front-matter): post.title defaults to filename if empty
e0b7c31 
hexojs/hexo#3672
@curbengh curbengh mentioned this pull request Sep 2, 2019
Merged
1 task
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@rupertqin
if post.title is empty, set it to post.slug (hexojs#3672)
0a75d3f
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
@stevenjoezhang stevenjoezhang mentioned this pull request Apr 22, 2020
Closed
@stevenjoezhang
Copy link
Member

stevenjoezhang commented Apr 22, 2020 •
edited
Loading

According to hexo-theme-unit-test, posts without title should be the feature of Hexo themes.

This Pull Request makes "Posts without title should be accessible" impossible. Need to reconsider this feature or update related documents.

https://github.com/hexojs/hexo-theme-unit-test#post
#4228

@SukkaW SukkaW mentioned this pull request Apr 22, 2020
Closed
@SukkaW
Copy link
Member

SukkaW commented Apr 25, 2020

#3672 (comment)

@stevenjoezhang Added to Hexo 5.0.0 Roadmap.

@stevenjoezhang stevenjoezhang mentioned this pull request Jun 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rupertqin @coveralls @stevenjoezhang @SukkaW @yoshinorin @curbengh