-
-
Notifications
You must be signed in to change notification settings - Fork 5k
Add hour and minute for the post permalink. #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can this be merged? |
It looks good, but no unit tests? |
https://github.com/hexojs/hexo/blob/master/test/scripts/filters/post_permalink.js#L84 Adding one does not seem complex, based upon existing ones Can you do one, or do you need help?
That should be a start :) |
Just a note that when hour and minute is enabled,
but front-matter of a post doesn't have hour+minute, the permalink will default them to zero, e.g. "2015/05/06/00/00/my-new-post/". |
CI benchmark doesn't look great, but I believe it's more likely due to Travis is under heavy load (on weekend). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@curbengh |
What does it do?
Add hour and minute for the post permalink.
How to test
Edit _config.yml file
Screenshots
Pull request tasks