fix: opens external anchor using rel=noopener #2728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Collaborator
Author
|
Any suggestions? cc @NoahDragon |
NoahDragon
reviewed
Aug 28, 2017
lib/plugins/helper/link_to.js
Outdated
| if (attrs.external) { | ||
| attrs.target = '_blank'; | ||
| attrs.rel = 'external'; | ||
| attrs.rel = 'noopener'; |
Member
There was a problem hiding this comment.
How about external noopener? I'm not sure if noopener already covers the external?
Collaborator
Author
There was a problem hiding this comment.
Good to go, I will rework on this PR.
test/scripts/helpers/link_to.js
Outdated
| it('external (boolean)', () => { | ||
| linkTo('http://hexo.io/', 'Hexo', true) | ||
| .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="external">Hexo</a>'); | ||
| .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="noopener">Hexo</a>'); |
Member
|
Sorry, I added review several days ago but forgot to submit them. |
Collaborator
Author
|
LGTM, @NoahDragon I suggest we publish a new patch version with latest hexo-log or bunyan-related dependencies. |
Member
|
@JLHwung Agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://developers.google.com/web/tools/lighthouse/audits/noopener
Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated: