Skip to content

enable async tags to have more nested async tags #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2017
Merged

enable async tags to have more nested async tags #2602

merged 4 commits into from
Jun 22, 2017

Conversation

@brian-mann
Copy link
Contributor

@brian-mann brian-mann commented Jun 9, 2017

nunchucks supports nested async tags.

this PR simple uses a callback function to properly chain these tags together

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.144% when pulling 7d926ac on cypress-io:master into 2d0af81 on hexojs:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage increased (+0.001%) to 97.144% when pulling d709e91 on cypress-io:master into 2d0af81 on hexojs:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage increased (+0.001%) to 97.144% when pulling d709e91 on cypress-io:master into 2d0af81 on hexojs:master.

@NoahDragon
Copy link
Member

NoahDragon commented Jun 14, 2017

Could you please fix the travis-ci errors?

@NoahDragon NoahDragon added the enhancement New feature or request label Jun 14, 2017
@coveralls
Copy link

coveralls commented Jun 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.144% when pulling 76b3456 on cypress-io:master into 2d0af81 on hexojs:master.

@coveralls
Copy link

coveralls commented Jun 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.144% when pulling 0f02a9f on cypress-io:master into 28f9626 on hexojs:master.

NoahDragon
NoahDragon approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahDragon NoahDragon merged commit 5a28258 into hexojs:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brian-mann @coveralls @NoahDragon @jennifer-shehane